jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/347572 )
Change subject: Fix `LexemeLanguageFieldObserver.tests.js` for jQuery 3.0
migration
......................................................................
Fix `LexemeLanguageFieldObserver.tests.js` for jQuery 3.0 migration
Test is failing because jQuery implementation is changed.
It used to set "display: block" disregarding the fact that
element is not in the visible DOM, now it does something differently.
Change-Id: I2a8ca23551ddec02812403b159ddc3b398cf5a9e
---
M tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
diff --git
a/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
b/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
index 846524c..452418e 100644
--- a/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
+++ b/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
@@ -43,9 +43,13 @@
getMockLanguageExtractor()
);
- assert.ok( $field.css( 'display' ) === 'none' );
+ $field.appendTo( 'body' );
+
+ assert.equal( $field.css( 'display' ), 'none' );
languageFieldObserver.notify( 'Q123' );
- assert.ok( $field.css( 'display' ) === 'block' );
+ assert.equal( $field.css( 'display' ), 'block' );
+
+ $field.remove();
} );
QUnit.test( 'Given the provided item has a language code statement,
lemma language field is hidden', function ( assert ) {
@@ -57,7 +61,7 @@
);
languageFieldObserver.notify( 'Q123' );
- assert.ok( $field.css( 'display' ) === 'none' );
+ assert.equal( $field.css( 'display' ), 'none' );
assert.equal( $field.find( 'input' ).val(), 'en' );
} );
--
To view, visit https://gerrit.wikimedia.org/r/347572
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a8ca23551ddec02812403b159ddc3b398cf5a9e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
