Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350394 )
Change subject: Remove unused parameter from SpecialModifyEntity and subclasses
......................................................................
Remove unused parameter from SpecialModifyEntity and subclasses
This clashes with other patches Lucas is currently doing! Please merge
his patches first. I will rebase this later.
Change-Id: I3ce9d6d9cfbf708b0be0843fbf74547fe9740c6e
---
M repo/includes/Specials/SpecialModifyEntity.php
M repo/includes/Specials/SpecialModifyTerm.php
M repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
3 files changed, 5 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/94/350394/1
diff --git a/repo/includes/Specials/SpecialModifyEntity.php
b/repo/includes/Specials/SpecialModifyEntity.php
index 49d7ed2..a790f28 100644
--- a/repo/includes/Specials/SpecialModifyEntity.php
+++ b/repo/includes/Specials/SpecialModifyEntity.php
@@ -53,10 +53,9 @@
/**
* @param string $title The title of the special page
- * @param string $restriction The required user right, 'edit' per
default.
*/
- public function __construct( $title, $restriction = 'edit' ) {
- parent::__construct( $title, $restriction );
+ public function __construct( $title ) {
+ parent::__construct( $title, 'edit' );
$wikibaseRepo = WikibaseRepo::getDefaultInstance();
$settings = $wikibaseRepo->getSettings();
diff --git a/repo/includes/Specials/SpecialModifyTerm.php
b/repo/includes/Specials/SpecialModifyTerm.php
index 3ee17c7..b604f2f 100644
--- a/repo/includes/Specials/SpecialModifyTerm.php
+++ b/repo/includes/Specials/SpecialModifyTerm.php
@@ -49,10 +49,9 @@
/**
* @param string $title The title of the special page
- * @param string $restriction The required user right, 'edit' per
default.
*/
- public function __construct( $title, $restriction = 'edit' ) {
- parent::__construct( $title, $restriction );
+ public function __construct( $title ) {
+ parent::__construct( $title );
$wikibaseRepo = WikibaseRepo::getDefaultInstance();
$changeOpFactoryProvider =
$wikibaseRepo->getChangeOpFactoryProvider();
diff --git a/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
b/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
index 7b489d5..fe99379 100644
--- a/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
+++ b/repo/includes/Specials/SpecialSetLabelDescriptionAliases.php
@@ -61,7 +61,7 @@
private $aliases = array();
public function __construct() {
- parent::__construct( 'SetLabelDescriptionAliases', 'edit' );
+ parent::__construct( 'SetLabelDescriptionAliases' );
$wikibaseRepo = WikibaseRepo::getDefaultInstance();
--
To view, visit https://gerrit.wikimedia.org/r/350394
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ce9d6d9cfbf708b0be0843fbf74547fe9740c6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
