Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350495 )

Change subject: Move fallback message to the currency_code slot
......................................................................

Move fallback message to the currency_code slot

This way it makes the fields editable and doesn't show the error
reference ID. Also needed to add a missing field_error slot

Bug: T98447
Change-Id: I8746d430bfb9793a339db72dc551ffd533340620
---
M gateway_common/gateway.adapter.php
M gateway_forms/mustache/index.html.mustache
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/95/350495/1

diff --git a/gateway_common/gateway.adapter.php 
b/gateway_common/gateway.adapter.php
index a7b360d..1564bcb 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -2556,7 +2556,7 @@
                // If we're configured to notify, or if there are already other 
errors,
                // add a notification message.
                if ( $notify || $this->errors ) {
-                       $error['general'] = 
MessageUtils::getCountrySpecificMessage(
+                       $error['currency_code'] = 
MessageUtils::getCountrySpecificMessage(
                                'donate_interface-fallback-currency-notice',
                                $this->dataObj->getVal( 'country' ),
                                $this->dataObj->getVal( 'language' ),
diff --git a/gateway_forms/mustache/index.html.mustache 
b/gateway_forms/mustache/index.html.mustache
index 0d85171..9639e01 100644
--- a/gateway_forms/mustache/index.html.mustache
+++ b/gateway_forms/mustache/index.html.mustache
@@ -21,6 +21,7 @@
                                        <table id="payment-table-donor">
                                                <tbody>
                                                {{{ fieldError "amount" }}}
+                                               {{{ fieldError "currency_code" 
}}}
                                                <tr>
                                                        <td>
                                                                <div 
id="step1header">

-- 
To view, visit https://gerrit.wikimedia.org/r/350495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8746d430bfb9793a339db72dc551ffd533340620
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to