Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350496 )
Change subject: Placeholders should not be block
......................................................................
Placeholders should not be block
After applying this fix, the reflow drops considerably.
Note there is still a 1-3px margin of error.
Bug: T146298
Change-Id: I44c5ab854260512a48b3a4f28624cbd172ffe55f
---
M resources/skins.minerva.base.styles/images.less
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/96/350496/1
diff --git a/resources/skins.minerva.base.styles/images.less
b/resources/skins.minerva.base.styles/images.less
index 5a28720..7945156 100644
--- a/resources/skins.minerva.base.styles/images.less
+++ b/resources/skins.minerva.base.styles/images.less
@@ -20,9 +20,12 @@
background-color: @placeholderBackgroundColor;
- // In order to avoid reflows placeholder needs to be block, or
- // inline-block+overflow:hidden given it is nested inside an inline <a>
- display: block;
+ // In order to avoid reflows placeholder
+ // inline-block
+ // Otherwise it will always take up the full line (as any block element
would)
+ // instead of allowing text before and after
+ // see T146298
+ display: inline-block;
}
// When the image has loaded transition background color and image opacity
--
To view, visit https://gerrit.wikimedia.org/r/350496
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44c5ab854260512a48b3a4f28624cbd172ffe55f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
