jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/350496 )
Change subject: Placeholders should not be block ...................................................................... Placeholders should not be block After applying this fix, the reflow drops considerably. Note there is still a 1-3px margin of error. This can be traced back to: I0bd6676a523669d47fede7714db3ab4b7b24fa4a which introduced them to combat an issue with reflow inside an image (see https://phabricator.wikimedia.org/T135430#2384461) This problem is not present now we use replaceWith rather than append. Bug: T146298 Change-Id: I44c5ab854260512a48b3a4f28624cbd172ffe55f --- M resources/skins.minerva.base.styles/images.less 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Krinkle: Looks good to me, but someone else must approve Jhernandez: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/skins.minerva.base.styles/images.less b/resources/skins.minerva.base.styles/images.less index 5a28720..f2d1a02 100644 --- a/resources/skins.minerva.base.styles/images.less +++ b/resources/skins.minerva.base.styles/images.less @@ -20,9 +20,11 @@ background-color: @placeholderBackgroundColor; - // In order to avoid reflows placeholder needs to be block, or - // inline-block+overflow:hidden given it is nested inside an inline <a> - display: block; + // In order to avoid reflows placeholder needs to be inline-block + // Otherwise display block will always take up the full line + // instead of allowing text before and after + // see T146298 + display: inline-block; } // When the image has loaded transition background color and image opacity -- To view, visit https://gerrit.wikimedia.org/r/350496 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44c5ab854260512a48b3a4f28624cbd172ffe55f Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Jhernandez <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
