jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351181 )
Change subject: Call LocalRenameUserJob::teardown in FixStuckGlobalRename
......................................................................
Call LocalRenameUserJob::teardown in FixStuckGlobalRename
FixStuckGlobalRename runs LocalRenameUserJob as a plain class, not
a job (probably to get better error output?), which resulted
in the job for the next wiki not being scheduled, since that's
done in teardown(), not in run().
Bug: T163622
Change-Id: I250ac2fac643bd5a36de6eba28309487ca88722d
---
M maintenance/fixStuckGlobalRename.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/fixStuckGlobalRename.php
b/maintenance/fixStuckGlobalRename.php
index 71e4608..45ccb78 100644
--- a/maintenance/fixStuckGlobalRename.php
+++ b/maintenance/fixStuckGlobalRename.php
@@ -94,8 +94,9 @@
$title = Title::newFromText( 'Global rename job' );
$job = new LocalRenameUserJob( $title, $params );
$this->output( "\nStarting to run job...\n" );
- $job->run();
- $this->output( "Done!\n" );
+ $status = $job->run();
+ $job->teardown( $status );
+ $this->output( $status ? "Done!\n" : "Failed!\n" );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/351181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I250ac2fac643bd5a36de6eba28309487ca88722d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
