Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351632 )
Change subject: Fixed Preview-Not-Close-Bug
......................................................................
Fixed Preview-Not-Close-Bug
The query preview clickover was not closed,
when the ESC key was hit, but the Query-Browser was,
resulting in an unclosable preview clickover.
By explicitly defining, that the clickover shall be
closed, when the ESC key is hit, this bug is fixed.
Change-Id: Ieb0305f4c010750ec34fd46b19fbf00e420b7a5a
---
M wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/32/351632/1
diff --git a/wikibase/queryService/ui/QueryExampleDialog.js
b/wikibase/queryService/ui/QueryExampleDialog.js
index 0d110b5..5fad8fb 100644
--- a/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/wikibase/queryService/ui/QueryExampleDialog.js
@@ -14,6 +14,7 @@
* @license GNU GPL v2+
*
* @author Jonas Kress
+ * @author Florian Rämisch, <[email protected]>
* @constructor
*
* @param {jQuery} $element
@@ -248,6 +249,7 @@
{
placement: 'left',
'global_close': true,
+ 'esc_close': true,
trigger: 'click',
container: 'body',
title: self._i18n(
'wdqs-dialog-examples-preview-result', 'Preview result' ),
--
To view, visit https://gerrit.wikimedia.org/r/351632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb0305f4c010750ec34fd46b19fbf00e420b7a5a
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Fraemisch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
