Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/351662 )
Change subject: All dd elements should use overflow scroll
......................................................................
All dd elements should use overflow scroll
If a dd element contains an image the image may extend out of
the viewport. To protect against this we make it overflow scroll.
This will not impact any text inside the dd and dd tag is already
display block so will not result in any UI regressions
Bug: T160946
Change-Id: I796a023e497a47655482bf35df85d2ff030c3dc6
---
M resources/skins.minerva.content.styles/lists.less
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/62/351662/1
diff --git a/resources/skins.minerva.content.styles/lists.less
b/resources/skins.minerva.content.styles/lists.less
index 4df0c01..69b6dc9 100644
--- a/resources/skins.minerva.content.styles/lists.less
+++ b/resources/skins.minerva.content.styles/lists.less
@@ -59,6 +59,12 @@
dt {
font-weight: bold;
}
+ dd {
+ display: block;
+ // Some dd's may contain images so we (see T160946)
+ // Text will not become scrollable.
+ overflow: scroll;
+ }
}
/* the following rule is completely copied from mediawiki.skinning.content[1],
as
--
To view, visit https://gerrit.wikimedia.org/r/351662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I796a023e497a47655482bf35df85d2ff030c3dc6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits