jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351662 )
Change subject: All dd elements should allow scrolling
......................................................................
All dd elements should allow scrolling
If a dd element contains an image the image may extend out of
the viewport. To protect against this we make it overflow scroll.
This will not impact any text inside the dd and dd tag is already
display block so will not result in any UI regressions
Using overflow: auto will show a scrollbar if needed but will not
show one if it is not. Using overflow: scroll would make all dd elements
show a scrollbar even when not necessary.
Bug: T160946
Change-Id: I796a023e497a47655482bf35df85d2ff030c3dc6
---
M resources/skins.minerva.content.styles/lists.less
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Physikerwelt: Looks good to me, but someone else must approve
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/skins.minerva.content.styles/lists.less
b/resources/skins.minerva.content.styles/lists.less
index 4df0c01..c44176a 100644
--- a/resources/skins.minerva.content.styles/lists.less
+++ b/resources/skins.minerva.content.styles/lists.less
@@ -59,6 +59,13 @@
dt {
font-weight: bold;
}
+ dd {
+ display: block;
+ // Some dd's may contain images so these need to be scrollable
+ // Text will not become scrollable.
+ // (see T160946)
+ overflow: auto;
+ }
}
/* the following rule is completely copied from mediawiki.skinning.content[1],
as
--
To view, visit https://gerrit.wikimedia.org/r/351662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I796a023e497a47655482bf35df85d2ff030c3dc6
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Physikerwelt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
