Inez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/52926
Change subject: Do not display phantoms while dragging mouse over alien nodes.
......................................................................
Do not display phantoms while dragging mouse over alien nodes.
It really does screw up selection in IE and does not look good in other
supported browsers.
Change-Id: I36992cabdb68b5a58388489669703599e3e58350
---
M modules/ve/ce/nodes/ve.ce.AlienNode.js
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/26/52926/1
diff --git a/modules/ve/ce/nodes/ve.ce.AlienNode.js
b/modules/ve/ce/nodes/ve.ce.AlienNode.js
index 5b32c84..be232ef 100644
--- a/modules/ve/ce/nodes/ve.ce.AlienNode.js
+++ b/modules/ve/ce/nodes/ve.ce.AlienNode.js
@@ -43,6 +43,9 @@
* @param {jQuery.Event} e Mouse enter event
*/
ve.ce.AlienNode.prototype.onMouseEnter = function () {
+ if ( this.getRoot().getSurface().dragging ) {
+ return;
+ }
var $phantoms = $( [] ),
$phantomTemplate = ve.ce.Surface.static.$phantomTemplate,
surface = this.root.getSurface();
--
To view, visit https://gerrit.wikimedia.org/r/52926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36992cabdb68b5a58388489669703599e3e58350
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
