jenkins-bot has submitted this change and it was merged.
Change subject: Do not display phantoms while dragging mouse over alien nodes.
......................................................................
Do not display phantoms while dragging mouse over alien nodes.
It really does screw up selection in IE and does not look good in other
supported browsers.
Change-Id: Ie190e86b25c3b253d4cf809594e74094275d0d57
---
M modules/ve/ce/nodes/ve.ce.AlienNode.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Robmoen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/nodes/ve.ce.AlienNode.js
b/modules/ve/ce/nodes/ve.ce.AlienNode.js
index 4da2f83..ece777c 100644
--- a/modules/ve/ce/nodes/ve.ce.AlienNode.js
+++ b/modules/ve/ce/nodes/ve.ce.AlienNode.js
@@ -50,7 +50,9 @@
var $phantoms = $( [] ),
$phantomTemplate = ve.ce.Surface.static.$phantomTemplate,
surface = this.root.getSurface();
-
+ if ( surface.dragging ) {
+ return;
+ }
this.$.find( '.ve-ce-node-shield' ).each( function () {
var $shield = $( this ),
offset = $shield.offset();
--
To view, visit https://gerrit.wikimedia.org/r/52927
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie190e86b25c3b253d4cf809594e74094275d0d57
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
