Austinoneil has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/362610 )
Change subject: Added the ability to find within page using ctrl-f or f3
......................................................................
Added the ability to find within page using ctrl-f or f3
Change-Id: I8b5657f78333caf658c29d611b7de8ed0efecc1a
---
M app/src/main/assets/bundle.js
M app/src/main/java/org/wikipedia/page/PageFragment.java
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/10/362610/1
diff --git a/app/src/main/assets/bundle.js b/app/src/main/assets/bundle.js
index 2d2593f..287829d 100644
--- a/app/src/main/assets/bundle.js
+++ b/app/src/main/assets/bundle.js
@@ -52,6 +52,21 @@
}
}
+var KEYCODE_F = 70;
+var KEYCODE_F3 = 114;
+
+document.onkeydown = function() {
+ if(event.ctrlKey) {
+ if(event.keyCode === KEYCODE_F) {
+ bridge.sendMessage('ctrlF', {});
+ }
+ }
+
+ if(event.keyCode === KEYCODE_F3) {
+ bridge.sendMessage('f3', {});
+ }
+};
+
document.onclick = function() {
var sourceNode = null;
var curNode = event.target;
diff --git a/app/src/main/java/org/wikipedia/page/PageFragment.java
b/app/src/main/java/org/wikipedia/page/PageFragment.java
index c878f65..3b03177 100755
--- a/app/src/main/java/org/wikipedia/page/PageFragment.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragment.java
@@ -1159,6 +1159,17 @@
}
}
});
+ bridge.addListener("ctrlF", new CommunicationBridge.JSEventListener() {
+ @Override public void onMessage(String messageType, JSONObject
messagePayload) {
+ showFindInPage();
+ }
+ });
+ bridge.addListener("f3", new CommunicationBridge.JSEventListener() {
+ @Override
+ public void onMessage(String messageType, JSONObject
messagePayload) {
+ showFindInPage();
+ }
+ });
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/362610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b5657f78333caf658c29d611b7de8ed0efecc1a
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Austinoneil <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
