Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365311 )
Change subject: Make a few unspecific array type hints more specific
......................................................................
Make a few unspecific array type hints more specific
The one in the .js file is an actual mistake, because the parameter is
not optional.
Change-Id: Ie381e97d49c8db018746d8dd31c085c7a1606209
---
M repo/tests/phpunit/includes/Api/EntityTestHelper.php
M view/resources/jquery/wikibase/jquery.wikibase.listview.js
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/11/365311/1
diff --git a/repo/tests/phpunit/includes/Api/EntityTestHelper.php
b/repo/tests/phpunit/includes/Api/EntityTestHelper.php
index 82bdd9c..7e0e72f 100644
--- a/repo/tests/phpunit/includes/Api/EntityTestHelper.php
+++ b/repo/tests/phpunit/includes/Api/EntityTestHelper.php
@@ -283,8 +283,8 @@
* Get the data of the entity with the given handle we received after
creation
*
* @param string $handle
- * @param null|array $props array of props we want the output to have
- * @param null|array $langs array of langs we want the output to have
+ * @param string[]|null $props Array of property keys we want the
output to have
+ * @param string[]|null $langs Array of language codes we want the
output to have
*
* @throws OutOfBoundsException
* @return mixed
@@ -304,8 +304,8 @@
* Remove props and langs that are not included in $props or $langs
from the $entityOutput array
*
* @param array $entityOutput Array of entity output
- * @param array $props Props to keep in the output
- * @param null|array $languageCodes Languages to keep in the output
+ * @param string[] $props Property keys to keep in the output
+ * @param string[]|null $languageCodes Languages to keep in the output
*
* @return array Array of entity output with props and langs removed
*/
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.listview.js
b/view/resources/jquery/wikibase/jquery.wikibase.listview.js
index 3c41c99..2aff4c4 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.listview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.listview.js
@@ -48,7 +48,7 @@
/**
* The DOM elements this `listview`'s element contained when it
was initialized. These DOM
* elements are reused in `this._addLiValue` until the array is
empty.
- * @property [HTMLElement[]]
+ * @property {HTMLElement[]|null}
* @private
*/
_reusedItems: null,
--
To view, visit https://gerrit.wikimedia.org/r/365311
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie381e97d49c8db018746d8dd31c085c7a1606209
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
