jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/365311 )
Change subject: Make a few unspecific array type hints more specific
......................................................................
Make a few unspecific array type hints more specific
The one in the .js file is an actual mistake, because the parameter is
not optional.
Change-Id: Ie381e97d49c8db018746d8dd31c085c7a1606209
---
M repo/tests/phpunit/includes/Api/EntityTestHelper.php
M view/resources/jquery/wikibase/jquery.wikibase.listview.js
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
AnotherLadsgroup: Looks good to me, but someone else must approve
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/Api/EntityTestHelper.php
b/repo/tests/phpunit/includes/Api/EntityTestHelper.php
index 82bdd9c..6f2beb5 100644
--- a/repo/tests/phpunit/includes/Api/EntityTestHelper.php
+++ b/repo/tests/phpunit/includes/Api/EntityTestHelper.php
@@ -283,11 +283,12 @@
* Get the data of the entity with the given handle we received after
creation
*
* @param string $handle
- * @param null|array $props array of props we want the output to have
- * @param null|array $langs array of langs we want the output to have
+ * @param string[]|null $props Keys of entity elements we want the
output to have.
+ * @param string[]|null $langs Language codes of labels, descriptions,
and aliases we want the
+ * output to have.
*
* @throws OutOfBoundsException
- * @return mixed
+ * @return array
*/
public static function getEntityOutput( $handle, array $props = null,
array $langs = null ) {
if ( !array_key_exists( $handle, self::$entityOutput ) ) {
@@ -304,8 +305,9 @@
* Remove props and langs that are not included in $props or $langs
from the $entityOutput array
*
* @param array $entityOutput Array of entity output
- * @param array $props Props to keep in the output
- * @param null|array $languageCodes Languages to keep in the output
+ * @param string[] $props Keys of entity elements to keep in the output.
+ * @param string[]|null $languageCodes Language codes of labels,
descriptions, and aliases to
+ * keep in the output.
*
* @return array Array of entity output with props and langs removed
*/
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.listview.js
b/view/resources/jquery/wikibase/jquery.wikibase.listview.js
index 3c41c99..2aff4c4 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.listview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.listview.js
@@ -48,7 +48,7 @@
/**
* The DOM elements this `listview`'s element contained when it
was initialized. These DOM
* elements are reused in `this._addLiValue` until the array is
empty.
- * @property [HTMLElement[]]
+ * @property {HTMLElement[]|null}
* @private
*/
_reusedItems: null,
--
To view, visit https://gerrit.wikimedia.org/r/365311
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie381e97d49c8db018746d8dd31c085c7a1606209
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: AnotherLadsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Maintenance-bot <ladsgr...@gmail.com>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
