Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365871 )

Change subject: Do not show warning box when LoginForm was posted
......................................................................

Do not show warning box when LoginForm was posted

Because there is no easy way to detect failed user login/account
creation, do not show warning box during POST request. This should
do the trick as there shouldn't be possible to display valid
login/usercreate form during POST request.

Bug: T149413
Change-Id: Ieb7a34068aaad99616ad6c43de48f70a6775882e
---
M includes/Minerva.hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/71/365871/1

diff --git a/includes/Minerva.hooks.php b/includes/Minerva.hooks.php
index dcb2894..f1ead6b 100644
--- a/includes/Minerva.hooks.php
+++ b/includes/Minerva.hooks.php
@@ -120,7 +120,8 @@
                                        // if no warning message set.
                                        if (
                                                !$request->getVal( 'warning', 
null ) &&
-                                               
!$special->getUser()->isLoggedIn()
+                                               
!$special->getUser()->isLoggedIn() &&
+                                               !$request->wasPosted()
                                        ) {
                                                $request->setVal( 'warning', 
'mobile-frontend-generic-login-new' );
                                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/365871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb7a34068aaad99616ad6c43de48f70a6775882e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to