jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/365871 )
Change subject: Do not show warning box when LoginForm was posted
......................................................................
Do not show warning box when LoginForm was posted
Because there is no easy way to detect failed user login/account
creation, do not show warning box during POST request. This should
do the trick as there shouldn't be possible to display valid
login/usercreate form during POST request.
Bug: T149413
Change-Id: Ieb7a34068aaad99616ad6c43de48f70a6775882e
Depends-On: I6ba28ddaeb0f9af17fa875bd9d1265509db4b927
---
M includes/Minerva.hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/includes/Minerva.hooks.php b/includes/Minerva.hooks.php
index f12bd4a..2f953de 100644
--- a/includes/Minerva.hooks.php
+++ b/includes/Minerva.hooks.php
@@ -116,7 +116,8 @@
// if no warning message set.
if (
!$request->getVal( 'warning',
null ) &&
-
!$special->getUser()->isLoggedIn()
+
!$special->getUser()->isLoggedIn() &&
+ !$request->wasPosted()
) {
$request->setVal( 'warning',
'mobile-frontend-generic-login-new' );
}
--
To view, visit https://gerrit.wikimedia.org/r/365871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb7a34068aaad99616ad6c43de48f70a6775882e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Pmiazga <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
