jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/367869 )
Change subject: Fix some parameter docs
......................................................................
Fix some parameter docs
Change-Id: Ie2ad528412778d3408c4b316beca883c0e5124e0
---
M WikiEditor.hooks.php
M phpcs.xml
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikiEditor.hooks.php b/WikiEditor.hooks.php
index 3feb713..af7821d 100644
--- a/WikiEditor.hooks.php
+++ b/WikiEditor.hooks.php
@@ -81,7 +81,7 @@
* This method is public to allow other extensions that use WikiEditor
to use the
* same configuration as WikiEditor itself
*
- * @param $name string Name of the feature, should be a key of $features
+ * @param string $name Name of the feature, should be a key of $features
* @return bool
*/
public static function isEnabled( $name ) {
@@ -249,7 +249,7 @@
*
* Disable the old toolbar if the new one is enabled
*
- * @param $toolbar html
+ * @param string &$toolbar
* @return bool
*/
public static function EditPageBeforeEditToolbar( &$toolbar ) {
@@ -273,7 +273,7 @@
* Adds WikiEditor-related items to the preferences
*
* @param User $user current user
- * @param array $defaultPreferences list of default user preference
controls
+ * @param array &$defaultPreferences list of default user preference
controls
* @return bool
*/
public static function getPreferences( $user, &$defaultPreferences ) {
@@ -381,7 +381,6 @@
* This is attached to the MediaWiki 'EditPage::attemptSave' hook.
*
* @param EditPage $editPage
- * @param Status $status
* @return bool
*/
public static function editPageAttemptSave( EditPage $editPage ) {
diff --git a/phpcs.xml b/phpcs.xml
index cb559ef..06f0ccb 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -5,7 +5,6 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
--
To view, visit https://gerrit.wikimedia.org/r/367869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2ad528412778d3408c4b316beca883c0e5124e0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
