MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371596 )

Change subject: Remove retrieval of deprecated pageviews statistics
......................................................................

Remove retrieval of deprecated pageviews statistics

Both $wgDisableCounters and SiteStats::views() do nothing
these days. Always return zero.

Change-Id: Ia2375fb3db31d1faade5f271e4725de64b10b55b
---
M engines/LuaCommon/SiteLibrary.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto 
refs/changes/96/371596/1

diff --git a/engines/LuaCommon/SiteLibrary.php 
b/engines/LuaCommon/SiteLibrary.php
index 68e8bae..4e6e7c5 100644
--- a/engines/LuaCommon/SiteLibrary.php
+++ b/engines/LuaCommon/SiteLibrary.php
@@ -8,7 +8,7 @@
        private $pagesInCategoryCache = [];
 
        function register() {
-               global $wgContLang, $wgNamespaceAliases, $wgDisableCounters;
+               global $wgContLang, $wgNamespaceAliases;
 
                $lib = [
                        'getNsIndex' => [ $this, 'getNsIndex' ],
@@ -82,7 +82,8 @@
                        'articles' => (int)SiteStats::articles(),
                        'files' => (int)SiteStats::images(),
                        'edits' => (int)SiteStats::edits(),
-                       'views' => $wgDisableCounters ? null : 
(int)SiteStats::views(),
+                       // @deprecated since 1.30, always zero. To be removed 
completely later.
+                       'views' => 0,
                        'users' => (int)SiteStats::users(),
                        'activeUsers' => (int)SiteStats::activeUsers(),
                        'admins' => (int)SiteStats::numberingroup( 'sysop' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/371596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2375fb3db31d1faade5f271e4725de64b10b55b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to