jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/370870 )
Change subject: mw.util: Add a deprecation message to escapeId() ...................................................................... mw.util: Add a deprecation message to escapeId() Bug: T172493 Change-Id: Ie1468a4c1b56ca79b5f978a8bba80e98d8871f51 --- M resources/src/mediawiki/mediawiki.util.js 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/resources/src/mediawiki/mediawiki.util.js b/resources/src/mediawiki/mediawiki.util.js index d0ec585..0e423be 100644 --- a/resources/src/mediawiki/mediawiki.util.js +++ b/resources/src/mediawiki/mediawiki.util.js @@ -66,17 +66,6 @@ rawurlencode: rawurlencode, /** - * Encode the string like Sanitizer::escapeId() in PHP - * @deprecated since 1.30 use escapeIdForAttribute() or escapeIdForLink() - * - * @param {string} str String to be encoded. - * @return {string} Encoded string - */ - escapeId: function ( str ) { - return escapeIdInternal( str, 'legacy' ); - }, - - /** * Encode string into HTML id compatible form suitable for use in HTML * Analog to PHP Sanitizer::escapeIdForAttribute() * @@ -605,6 +594,18 @@ }, 'Use mw.notify instead.' ); /** + * Encode the string like Sanitizer::escapeId() in PHP + * + * @method escapeId + * @deprecated since 1.30 use escapeIdForAttribute() or escapeIdForLink() + * @param {string} str String to be encoded. + * @return {string} Encoded string + */ + mw.log.deprecate( util, 'escapeId', function ( str ) { + return escapeIdInternal( str, 'legacy' ); + }, 'Use mw.util.escapeIdForAttribute or mw.util.escapeIdForLink instead.' ); + + /** * Initialisation of mw.util.$content */ function init() { -- To view, visit https://gerrit.wikimedia.org/r/370870 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1468a4c1b56ca79b5f978a8bba80e98d8871f51 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits