Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375021 )
Change subject: Remove use of deprecated EditPage::getCheckboxes()
......................................................................
Remove use of deprecated EditPage::getCheckboxes()
Follow-up to I5bfca5e116fe790302c3b6ac1357e80237fb1ed2.
Bug: T174613
Change-Id: I5747871065416ca23038b099f128b02b5cbb431b
---
M ApiVisualEditor.php
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/21/375021/1
diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php
index f508f10..7983f75 100644
--- a/ApiVisualEditor.php
+++ b/ApiVisualEditor.php
@@ -442,15 +442,12 @@
$req->setVal( 'format',
$editPage->contentFormat );
// By reference for some reason (T54466)
$editPage->importFormData( $req );
- $tabindex = 0;
$states = [
'minor' => $user->getOption(
'minordefault' ) && $title->exists(),
'watch' => $user->getOption(
'watchdefault' ) ||
( $user->getOption(
'watchcreations' ) && !$title->exists() ) ||
$user->isWatched( $title ),
];
- $checkboxes = method_exists( $editPage,
'getCheckboxes' )
- ? $editPage->getCheckboxes( $tabindex,
$states ) : '';
$checkboxesDef =
$editPage->getCheckboxesDefinition( $states );
$checkboxesMessages = [];
foreach ( $checkboxesDef as $name => $options )
{
@@ -517,7 +514,6 @@
$result = [
'result' => 'success',
'notices' => $notices,
- 'checkboxes' => $checkboxes,
'checkboxesDef' => $checkboxesDef,
'checkboxesMessages' =>
$checkboxesMessages,
'templates' => $templates,
--
To view, visit https://gerrit.wikimedia.org/r/375021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5747871065416ca23038b099f128b02b5cbb431b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
