WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375022 )
Change subject: Include back qualifier hashes
......................................................................
Include back qualifier hashes
Dropping them would be a breaking change in public APIs of Wikidata.
Switching to the new generic no-snak-hasehs option of the
SerializerFactory can happen after such change has been announced.
Change-Id: I95cd7d1f9ce0523d6256d47c0fdd2eefd1f82b2e
---
M data-access/src/GenericServices.php
M repo/includes/WikibaseRepo.php
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/22/375022/1
diff --git a/data-access/src/GenericServices.php
b/data-access/src/GenericServices.php
index 7f6d1f2..1b4605f 100644
--- a/data-access/src/GenericServices.php
+++ b/data-access/src/GenericServices.php
@@ -116,7 +116,11 @@
* but not about other entity types.
*/
public function getCompactBaseDataModelSerializerFactory() {
- return new SerializerFactory( new DataValueSerializer(),
SerializerFactory::OPTION_SERIALIZE_SNAKS_WITHOUT_HASH );
+ return new SerializerFactory(
+ new DataValueSerializer(),
+
SerializerFactory::OPTION_SERIALIZE_MAIN_SNAKS_WITHOUT_HASH +
+
SerializerFactory::OPTION_SERIALIZE_REFERENCE_SNAKS_WITHOUT_HASH
+ );
}
/**
diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php
index 962c8f7..a58a5b8 100644
--- a/repo/includes/WikibaseRepo.php
+++ b/repo/includes/WikibaseRepo.php
@@ -1414,7 +1414,11 @@
return
$this->wikibaseServices->getCompactBaseDataModelSerializerFactory();
}
- return new SerializerFactory( new DataValueSerializer(),
SerializerFactory::OPTION_SERIALIZE_SNAKS_WITHOUT_HASH );
+ return new SerializerFactory(
+ new DataValueSerializer(),
+
SerializerFactory::OPTION_SERIALIZE_MAIN_SNAKS_WITHOUT_HASH +
+
SerializerFactory::OPTION_SERIALIZE_REFERENCE_SNAKS_WITHOUT_HASH
+ );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/375022
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95cd7d1f9ce0523d6256d47c0fdd2eefd1f82b2e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
