jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/378751 )
Change subject: Design tweak: Update size and padding of reference dialog
components
......................................................................
Design tweak: Update size and padding of reference dialog components
Bug: T171469
Change-Id: Ibb3ad547599a73b78cf69f46178752fe83f46ba6
---
M app/src/main/res/layout/dialog_reference.xml
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/app/src/main/res/layout/dialog_reference.xml
b/app/src/main/res/layout/dialog_reference.xml
index 085a0e0..9ba1c63 100644
--- a/app/src/main/res/layout/dialog_reference.xml
+++ b/app/src/main/res/layout/dialog_reference.xml
@@ -6,13 +6,13 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:background="?attr/bottom_sheet_background_color"
- android:orientation="vertical"
- android:padding="16dp">
+ android:orientation="vertical">
<org.wikipedia.views.AppTextView
android:id="@+id/reference_title_text"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:padding="16dp"
style="@style/RtlAwareTextView"
android:textSize="16sp"
android:fontFamily="sans-serif-medium"
@@ -22,17 +22,17 @@
<View
android:layout_width="match_parent"
android:layout_height="0.5dp"
- android:layout_marginTop="16dp"
- android:layout_marginBottom="16dp"
android:theme="?attr/horizontal_divider" />
<org.wikipedia.views.AppTextView
android:id="@+id/reference_text"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:layout_marginBottom="4dp"
+ android:minHeight="72dp"
+ android:paddingLeft="16dp"
+ android:paddingRight="16dp"
style="@style/RtlAwareTextView"
- android:layout_gravity="start|center_vertical"
+ android:gravity="center_vertical"
android:textIsSelectable="true"
android:textColor="?android:textColorPrimary"
android:textColorLink="?attr/colorAccent"
--
To view, visit https://gerrit.wikimedia.org/r/378751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb3ad547599a73b78cf69f46178752fe83f46ba6
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits