jenkins-bot has submitted this change and it was merged.

Change subject: Call loadPageData() as needed in Title::moveToInternal.
......................................................................


Call loadPageData() as needed in Title::moveToInternal.

* This avoids use of a slave for loading the page ID to do
  the updates using $newpage. That bug prevented page moves
  by using the old 0 ID and throwing an exception.

Bug: 46397
Change-Id: Iea3259dce6840e3f2959d98a20177acd60433b64
---
M includes/Title.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Title.php b/includes/Title.php
index e81023a..84848eb 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3838,6 +3838,7 @@
 
                $this->resetArticleID( 0 );
                $nt->resetArticleID( $oldid );
+               $newpage->loadPageData( WikiPage::READ_LOCKING ); // bug 46397
 
                $newpage->updateRevisionOn( $dbw, $nullRevision );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/55017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea3259dce6840e3f2959d98a20177acd60433b64
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to