Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/55218


Change subject: Call loadPageData() as needed in Title::moveToInternal.
......................................................................

Call loadPageData() as needed in Title::moveToInternal.

* Follows up 61c0064de538c3b1ea61470eadd88fab87d3513e,
  which was missing a load call to fully fix the bug.
* The redirect title was triggering a load from a slave in
  updateRevisionOn() and wrongly updating the destination page
  to point to the redirect revision and leaving the redirect
  page with page_latest=0;

Bug : 46397
Change-Id: Id6abe062a0266a790716df8c592911fd89b83223
---
M includes/Title.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/18/55218/1

diff --git a/includes/Title.php b/includes/Title.php
index 84848eb..a79d862 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3858,6 +3858,7 @@
                        $redirectArticle = WikiPage::factory( $this );
                        $newid = $redirectArticle->insertOn( $dbw );
                        if ( $newid ) { // sanity
+                               $redirectArticle->loadPageData( 
WikiPage::READ_LOCKING ); // bug 46397
                                $redirectRevision = new Revision( array(
                                        'title'   => $this, // for determining 
the default content model
                                        'page'    => $newid,

-- 
To view, visit https://gerrit.wikimedia.org/r/55218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6abe062a0266a790716df8c592911fd89b83223
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to