Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391578 )

Change subject: Use calculated thresholds
......................................................................

Use calculated thresholds

Bug: T176914
Change-Id: I0bc4f2e57aa2b11226268b8883e05d3ffd8a3363
---
M puppet/modules/role/manifests/ores_service.pp
1 file changed, 5 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/78/391578/1

diff --git a/puppet/modules/role/manifests/ores_service.pp 
b/puppet/modules/role/manifests/ores_service.pp
index f5d646b..19296a0 100644
--- a/puppet/modules/role/manifests/ores_service.pp
+++ b/puppet/modules/role/manifests/ores_service.pp
@@ -17,28 +17,22 @@
                 reverted  => false,
                 wp10      => false,
             },
-            # the mock scorer used by the local service cannot
-            # provide recall stats so dynamic threshold configuration
-            # would cause score fetches to silently fail. Use a
-            # constant dummy configuration instead.
+            # Use calculated thresholds.
             wgOresFiltersThresholds => {
                 damaging => {
                     likelygood    => {
                         min => 0,
-                        max => 0.3,
+                        max => 'recall_at_precision(min_precision=0.99)',
                     },
                     maybebad      => {
-                        min => 0.2,
+                        min => 'recall_at_precision(min_precision=0.15)',
                         max => 1,
                     },
                     likelybad     => {
-                        min => 0.5,
+                        min => 'recall_at_precision(min_precision=0.45)',
                         max => 1,
                     },
-                    verylikelybad => {
-                        min => 0.8,
-                        max => 1,
-                    },
+                    # verylikelybad uses default
                 },
             },
         },

-- 
To view, visit https://gerrit.wikimedia.org/r/391578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bc4f2e57aa2b11226268b8883e05d3ffd8a3363
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to