jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391578 )
Change subject: Use calculated thresholds
......................................................................
Use calculated thresholds
Bug: T176914
Change-Id: I0bc4f2e57aa2b11226268b8883e05d3ffd8a3363
---
M puppet/modules/role/manifests/ores_service.pp
1 file changed, 8 insertions(+), 14 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
jenkins-bot: Verified
diff --git a/puppet/modules/role/manifests/ores_service.pp
b/puppet/modules/role/manifests/ores_service.pp
index f5d646b..f0ba461 100644
--- a/puppet/modules/role/manifests/ores_service.pp
+++ b/puppet/modules/role/manifests/ores_service.pp
@@ -17,28 +17,22 @@
reverted => false,
wp10 => false,
},
- # the mock scorer used by the local service cannot
- # provide recall stats so dynamic threshold configuration
- # would cause score fetches to silently fail. Use a
- # constant dummy configuration instead.
+ # Use calculated thresholds.
wgOresFiltersThresholds => {
damaging => {
- likelygood => {
+ likelygood => {
min => 0,
- max => 0.3,
+ max => 'recall_at_precision(min_precision=0.99)',
},
- maybebad => {
- min => 0.2,
+ maybebad => {
+ min => 'recall_at_precision(min_precision=0.15)',
max => 1,
},
- likelybad => {
- min => 0.5,
+ likelybad => {
+ min => 'recall_at_precision(min_precision=0.45)',
max => 1,
},
- verylikelybad => {
- min => 0.8,
- max => 1,
- },
+ # verylikelybad uses default
},
},
},
--
To view, visit https://gerrit.wikimedia.org/r/391578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bc4f2e57aa2b11226268b8883e05d3ffd8a3363
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Dduvall <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
