Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391838 )
Change subject: Prevent TypeError when parsing protection objects from MW API
......................................................................
Prevent TypeError when parsing protection objects from MW API
Guard against undefined protection fields before passing to simplify-
ProtectionObject.
Change-Id: I9013e4330bb3803eeb1006e2bda88f4feadab99f
---
M lib/mwapi.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/38/391838/1
diff --git a/lib/mwapi.js b/lib/mwapi.js
index 7bb49ca..4768e77 100644
--- a/lib/mwapi.js
+++ b/lib/mwapi.js
@@ -212,7 +212,7 @@
const image = page.pageimage ? {
file: page.pageimage
} : undefined;
- const protection = mwapi.simplifyProtectionObject(page.protection);
+ const protection = page.protection &&
mwapi.simplifyProtectionObject(page.protection);
const modifier = revision && revision.anon !== undefined ? { anon:
true } : {};
modifier.user = revision && revision.user;
// Always set to unknown until support in API added (T172228)
--
To view, visit https://gerrit.wikimedia.org/r/391838
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9013e4330bb3803eeb1006e2bda88f4feadab99f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
