jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391838 )
Change subject: Prevent TypeError when parsing protection objects from MW API
......................................................................
Prevent TypeError when parsing protection objects from MW API
Guard against undefined protection fields before passing to simplify-
ProtectionObject.
Change-Id: I9013e4330bb3803eeb1006e2bda88f4feadab99f
---
M lib/mwapi.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/mwapi.js b/lib/mwapi.js
index 7bb49ca..ef8c211 100644
--- a/lib/mwapi.js
+++ b/lib/mwapi.js
@@ -212,7 +212,7 @@
const image = page.pageimage ? {
file: page.pageimage
} : undefined;
- const protection = mwapi.simplifyProtectionObject(page.protection);
+ const protection = page.protection &&
mwapi.simplifyProtectionObject(page.protection);
const modifier = revision && revision.anon !== undefined ? { anon:
true } : {};
modifier.user = revision && revision.user;
// Always set to unknown until support in API added (T172228)
@@ -244,7 +244,7 @@
talkNs: talkNsText ? page.ns + 1 : undefined,
talkNsText,
protection,
- editable: !protection.edit,
+ editable: protection && !protection.edit,
mainpage,
revision: revision && revision.revid,
description: page.terms && page.terms.description[0],
--
To view, visit https://gerrit.wikimedia.org/r/391838
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9013e4330bb3803eeb1006e2bda88f4feadab99f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
