Addshore has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392460 )

Change subject: Deprecate access to TitleValue properties
......................................................................

Deprecate access to TitleValue properties

This switches from private to protected access of TitleValue
properties, and marks them as deprecated instead as per the
deprecation policy.

Partial revert of I3d8315ade6aa70bda43d90b0b32b730d8c9cbd2e

Change-Id: Ie290b6a84635ebb5865e82ae24fe4b27224e601a
---
M includes/title/TitleValue.php
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/392460/1

diff --git a/includes/title/TitleValue.php b/includes/title/TitleValue.php
index e2ee967..77c1953 100644
--- a/includes/title/TitleValue.php
+++ b/includes/title/TitleValue.php
@@ -36,24 +36,28 @@
 class TitleValue implements LinkTarget {
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for 
access.
         * @var int
         */
-       private $namespace;
+       protected $namespace;
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for 
access.
         * @var string
         */
-       private $dbkey;
+       protected $dbkey;
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for 
access.
         * @var string
         */
-       private $fragment;
+       protected $fragment;
 
        /**
+        * @deprecated in 1.31. This class is immutable. Use the getter for 
access.
         * @var string
         */
-       private $interwiki;
+       protected $interwiki;
 
        /**
         * Constructs a TitleValue.

-- 
To view, visit https://gerrit.wikimedia.org/r/392460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie290b6a84635ebb5865e82ae24fe4b27224e601a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to