jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392460 )
Change subject: Deprecate access to TitleValue properties
......................................................................
Deprecate access to TitleValue properties
This switches from private to protected access of TitleValue
properties, and marks them as deprecated instead as per the
deprecation policy.
Partial revert of I3d8315ade6aa70bda43d90b0b32b730d8c9cbd2e
Change-Id: Ie290b6a84635ebb5865e82ae24fe4b27224e601a
---
M RELEASE-NOTES-1.31
M includes/title/TitleValue.php
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index a76ce0b..8caab05 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -96,6 +96,8 @@
* Due to significant refactoring, method ContribsPager::getUserCond() that had
no access restriction has been removed.
* Revision::setUserIdAndName() was deprecated.
+* Access to TitleValue class properties was deprecated, the relevant getters
+ should be used instead.
== Compatibility ==
MediaWiki 1.31 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/includes/title/TitleValue.php b/includes/title/TitleValue.php
index e2ee967..77c1953 100644
--- a/includes/title/TitleValue.php
+++ b/includes/title/TitleValue.php
@@ -36,24 +36,28 @@
class TitleValue implements LinkTarget {
/**
+ * @deprecated in 1.31. This class is immutable. Use the getter for
access.
* @var int
*/
- private $namespace;
+ protected $namespace;
/**
+ * @deprecated in 1.31. This class is immutable. Use the getter for
access.
* @var string
*/
- private $dbkey;
+ protected $dbkey;
/**
+ * @deprecated in 1.31. This class is immutable. Use the getter for
access.
* @var string
*/
- private $fragment;
+ protected $fragment;
/**
+ * @deprecated in 1.31. This class is immutable. Use the getter for
access.
* @var string
*/
- private $interwiki;
+ protected $interwiki;
/**
* Constructs a TitleValue.
--
To view, visit https://gerrit.wikimedia.org/r/392460
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie290b6a84635ebb5865e82ae24fe4b27224e601a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
