Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392659 )
Change subject: Follow-up I80d82ad87: Only add linebreak to existing documents
......................................................................
Follow-up I80d82ad87: Only add linebreak to existing documents
This is the same behaviour as the old editor, and
unbreaks editors that use placeholders.
Change-Id: I7b5a18f1fb0d41c5dc08d1b893c90db2bf3dbd86
---
M modules/ve-mw/init/ve.init.mw.Target.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/59/392659/1
diff --git a/modules/ve-mw/init/ve.init.mw.Target.js
b/modules/ve-mw/init/ve.init.mw.Target.js
index 08d17f2..3375f81 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -191,9 +191,11 @@
ve.init.mw.Target.static.parseDocument = function ( documentString, mode ) {
var doc;
if ( mode === 'source' ) {
- // Add trailing linebreak to wikitext documents for consistency
+ // Add trailing linebreak to existing wikitext documents for
consistency
// with old editor and usability. Will be stripped on save.
T156609
- documentString += '\n';
+ if ( documentString ) {
+ documentString += '\n';
+ }
// Parent method
doc = ve.init.mw.Target.super.static.parseDocument.call( this,
documentString, mode );
} else {
--
To view, visit https://gerrit.wikimedia.org/r/392659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b5a18f1fb0d41c5dc08d1b893c90db2bf3dbd86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
