jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392659 )
Change subject: Follow-up I80d82ad87: Only add linebreak to non-empty documents
......................................................................
Follow-up I80d82ad87: Only add linebreak to non-empty documents
This is the same behaviour as the old editor, and
unbreaks editors that use placeholders.
Change-Id: I7b5a18f1fb0d41c5dc08d1b893c90db2bf3dbd86
---
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 781af06..7896af8 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -215,9 +215,9 @@
* @inheritdoc
*/
ve.init.mw.ArticleTarget.static.parseDocument = function ( documentString,
mode ) {
- // Add trailing linebreak to wikitext documents for consistency
+ // Add trailing linebreak to non-empty wikitext documents for
consistency
// with old editor and usability. Will be stripped on save. T156609
- if ( mode === 'source' ) {
+ if ( mode === 'source' && documentString ) {
documentString += '\n';
}
--
To view, visit https://gerrit.wikimedia.org/r/392659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b5a18f1fb0d41c5dc08d1b893c90db2bf3dbd86
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
