jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393110 )
Change subject: Remove method level @group Database tags
......................................................................
Remove method level @group Database tags
MessageTest did not have the group at class level
either so that is added in this patch.
Change-Id: Idb6213282d6854044f374c9df51ea32d0a5523e1
---
M tests/phpunit/includes/ExtraParserTest.php
M tests/phpunit/includes/MessageTest.php
M tests/phpunit/includes/TitleTest.php
M tests/phpunit/includes/content/TextContentTest.php
4 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/ExtraParserTest.php
b/tests/phpunit/includes/ExtraParserTest.php
index a4e3bb9..aaa135d 100644
--- a/tests/phpunit/includes/ExtraParserTest.php
+++ b/tests/phpunit/includes/ExtraParserTest.php
@@ -193,7 +193,6 @@
}
/**
- * @group Database
* @covers Parser::parse
*/
public function testTrackingCategory() {
@@ -207,7 +206,6 @@
}
/**
- * @group Database
* @covers Parser::parse
*/
public function testTrackingCategorySpecial() {
diff --git a/tests/phpunit/includes/MessageTest.php
b/tests/phpunit/includes/MessageTest.php
index 912bffe..f99cccd 100644
--- a/tests/phpunit/includes/MessageTest.php
+++ b/tests/phpunit/includes/MessageTest.php
@@ -2,6 +2,9 @@
use Wikimedia\TestingAccessWrapper;
+/**
+ * @group Database
+ */
class MessageTest extends MediaWikiLangTestCase {
protected function setUp() {
@@ -467,7 +470,6 @@
/**
* FIXME: This should not need database, but Language#formatExpiry does
(T57912)
- * @group Database
* @covers Message::expiryParam
* @covers Message::expiryParams
*/
diff --git a/tests/phpunit/includes/TitleTest.php
b/tests/phpunit/includes/TitleTest.php
index b0febe8..5a92b99 100644
--- a/tests/phpunit/includes/TitleTest.php
+++ b/tests/phpunit/includes/TitleTest.php
@@ -282,7 +282,6 @@
/**
* Auth-less test of Title::isValidMoveOperation
*
- * @group Database
* @param string $source
* @param string $target
* @param array|string|bool $expected Required error
diff --git a/tests/phpunit/includes/content/TextContentTest.php
b/tests/phpunit/includes/content/TextContentTest.php
index b290f8f..1601493 100644
--- a/tests/phpunit/includes/content/TextContentTest.php
+++ b/tests/phpunit/includes/content/TextContentTest.php
@@ -212,7 +212,6 @@
/**
* @dataProvider dataIsCountable
- * @group Database
* @covers TextContent::isCountable
*/
public function testIsCountable( $text, $hasLinks, $mode, $expected ) {
--
To view, visit https://gerrit.wikimedia.org/r/393110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb6213282d6854044f374c9df51ea32d0a5523e1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
