DCausse has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393125 )

Change subject: Fix create_new_page.feature with ruby
......................................................................

Fix create_new_page.feature with ruby

I think this test was broken, the step it refers to does not
exist and some of the queries used could no match to Catapult.

Change-Id: Ibacb14218608e05b9c806171d536581dc89c2a6c
---
M tests/browser/features/create_new_page.feature
1 file changed, 30 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/25/393125/1

diff --git a/tests/browser/features/create_new_page.feature 
b/tests/browser/features/create_new_page.feature
index e92a9e5..ff628d9 100644
--- a/tests/browser/features/create_new_page.feature
+++ b/tests/browser/features/create_new_page.feature
@@ -23,39 +23,39 @@
   Scenario Outline: boolean operators in bad positions in the query are 
ignored so you get the option to create a new page
     When I search for <query>
     Then there is no warning
-      And Catapult is in the first search result
+      And <page> is the first search result
       And there is a link to create a new page from the search result
   Examples:
-  |         query          |
-  | catapult +             |
-  | catapult -             |
-  | catapult !             |
+  |         query          |     page         |
+  | catapult +             | Catapult         |
+  | catapult -             | Catapult         |
+  | catapult !             | Catapult         |
   # Bug 60362
-  #| catapult AND           |
-  #| catapult OR            |
-  #| catapult NOT           |
-  | + catapult             |
-  | - catapult             |
-  | ! catapult             |
+  #| catapult AND           | Catapult         |
+  #| catapult OR            | Catapult         |
+  #| catapult NOT           | Catapult         |
+  | + catapult             | Catapult         |
+  | - catapult             | Catapult         |
+  | ! catapult             | Catapult         |
   # Bug 60362
-  #| AND catapult           |
-  #| OR catapult            |
-  | catapult + amazing     |
-  | catapult - amazing     |
-  | catapult ! amazing     |
-  | amazing+catapult       |
-  | amazing-catapult       |
-  | amazing!catapult       |
-  | catapult!!!!!!!        |
-  | catapult !!!!!!!!      |
-  | !!!! catapult          |
-  | ------- catapult       |
-  | ++++ catapult ++++     |
-  | ++amazing++++catapult  |
-  | catapult ~/            |
-  | catapult ~/            |
-  | amazing~◆~catapult     |
-  | ******* catapult       |
+  #| AND catapult           | Catapult         |
+  #| OR catapult            | Catapult         |
+  | catapult + amazing     | Amazing Catapult |
+  | catapult - amazing     | Amazing Catapult |
+  | catapult ! amazing     | Amazing Catapult |
+  | amazing+catapult       | Amazing Catapult |
+  | amazing-catapult       | Amazing Catapult |
+  | amazing!catapult       | Amazing Catapult |
+  | catapult!!!!!!!        | Catapult         |
+  | catapult !!!!!!!!      | Catapult         |
+  | !!!! catapult          | Catapult         |
+  | ------- catapult       | Catapult         |
+  | ++++ catapult ++++     | Catapult         |
+  | ++amazing++++catapult  | Amazing Catapult |
+  | catapult ~/            | Catapult         |
+  | catapult ~/            | Catapult         |
+  | amazing~◆~catapult     | Amazing Catapult |
+  | ******* catapult       | Catapult         |
 
   @boolean_operators
   Scenario Outline: boolean operators in bad positions in the query are 
ignored but if there are other valid operators then you don't get the option to 
create a new page
@@ -81,7 +81,7 @@
   Scenario Outline: boolean operators in bad positions in the query are 
ignored and if the title isn't a valid article title then you don't get the 
option to create a new page
     When I search for <query>
     Then there is no warning
-      And Catapult is in the first search result
+      And Catapult is the first search result
       And there is no link to create a new page from the search result
   Examples:
   |         query          |

-- 
To view, visit https://gerrit.wikimedia.org/r/393125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibacb14218608e05b9c806171d536581dc89c2a6c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: DCausse <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to