Aaron Schulz has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394493 )
Change subject: Add temporary logging for bad WAN cache statsd keys
......................................................................
Add temporary logging for bad WAN cache statsd keys
Bug: T178531
Change-Id: Iabb0b42a3825364c093212ef2761272280813425
---
M extensions/AdvancedSearch
M extensions/ContentTranslation
M extensions/ORES
M extensions/WikimediaMessages
M includes/libs/objectcache/WANObjectCache.php
5 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/93/394493/1
diff --git a/extensions/AdvancedSearch b/extensions/AdvancedSearch
index 8a90e5a..c50e5da 160000
--- a/extensions/AdvancedSearch
+++ b/extensions/AdvancedSearch
@@ -1 +1 @@
-Subproject commit 8a90e5a31622ce4b759af41ee49d1b971b1d6cbd
+Subproject commit c50e5da73aa02ef571aed92608f4015673b8bfec
diff --git a/extensions/ContentTranslation b/extensions/ContentTranslation
index 78f590d..1c63ac8 160000
--- a/extensions/ContentTranslation
+++ b/extensions/ContentTranslation
@@ -1 +1 @@
-Subproject commit 78f590d5b524522ba4801bb0d41562c4b089bcf1
+Subproject commit 1c63ac8eb60c30323b3a080e1b3fa2f43bbbdd92
diff --git a/extensions/ORES b/extensions/ORES
index fffc274..ed88ffb 160000
--- a/extensions/ORES
+++ b/extensions/ORES
@@ -1 +1 @@
-Subproject commit fffc274c2f305220f2f86b49cb00d8e4d8f50a26
+Subproject commit ed88ffbb007926b43f4e6dc8f67685f689fa4312
diff --git a/extensions/WikimediaMessages b/extensions/WikimediaMessages
index eb17877..76b13c3 160000
--- a/extensions/WikimediaMessages
+++ b/extensions/WikimediaMessages
@@ -1 +1 @@
-Subproject commit eb17877aacebe53b103b1e0decdbaf2e8687ba3e
+Subproject commit 76b13c3117b09aa62f8b6fdab33a9d2d01878f99
diff --git a/includes/libs/objectcache/WANObjectCache.php
b/includes/libs/objectcache/WANObjectCache.php
index b8d90d9..3921a97 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -980,6 +980,12 @@
// Get a collection name to describe this class of key
$kClass = $this->determineKeyClass( $key );
+ if ( preg_match( '/^[0-9a-f]{32}$/', $kClass ) ) {
+ $this->logger->warning(
+ "Got bad statsd class for key '{key}'",
+ [ 'key' => $key, 'trace' => ( new
RuntimeException() )->getTraceAsString() ]
+ );
+ }
// Get the current key value
$curTTL = null;
--
To view, visit https://gerrit.wikimedia.org/r/394493
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabb0b42a3825364c093212ef2761272280813425
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.10
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
