jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394493 )
Change subject: Add temporary logging for bad WAN cache statsd keys
......................................................................
Add temporary logging for bad WAN cache statsd keys
Bug: T178531
Change-Id: Iabb0b42a3825364c093212ef2761272280813425
---
M includes/libs/objectcache/WANObjectCache.php
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
Krinkle: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/libs/objectcache/WANObjectCache.php
b/includes/libs/objectcache/WANObjectCache.php
index b8d90d9..3921a97 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -980,6 +980,12 @@
// Get a collection name to describe this class of key
$kClass = $this->determineKeyClass( $key );
+ if ( preg_match( '/^[0-9a-f]{32}$/', $kClass ) ) {
+ $this->logger->warning(
+ "Got bad statsd class for key '{key}'",
+ [ 'key' => $key, 'trace' => ( new
RuntimeException() )->getTraceAsString() ]
+ );
+ }
// Get the current key value
$curTTL = null;
--
To view, visit https://gerrit.wikimedia.org/r/394493
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabb0b42a3825364c093212ef2761272280813425
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.31.0-wmf.10
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
