WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394970 )
Change subject: Skip fewer tests in ViewEntityActionTest
......................................................................
Skip fewer tests in ViewEntityActionTest
Change-Id: I365440ba07e85f9e3b9f5c8309694a068601d3b1
---
M repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/70/394970/1
diff --git a/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
b/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
index dff032d..5b4d147 100644
--- a/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
+++ b/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
@@ -102,7 +102,7 @@
$output = $this->executeViewAction( $page, $params );
$this->assertContains( 'diff-currentversion-title',
$output->getHTML(), 'is diff view' );
- $this->assertNotEditable( $output );
+ $this->markTestSkipped( 'Diff page is currently editable, needs
fixing: T181807' );
}
public function testShowOldRevision_hasNoEditLinks() {
@@ -191,7 +191,6 @@
}
private function assertNotEditable( OutputPage $output ) {
- $this->markTestSkipped( 'Diff page is currently editable, needs
fixing: T181807' );
$html = $output->getHTML();
$this->assertNotContains( 'wikibase-edittoolbar-container',
$html );
$this->assertNotContains( 'wikibase-toolbar-button-edit', $html
);
--
To view, visit https://gerrit.wikimedia.org/r/394970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I365440ba07e85f9e3b9f5c8309694a068601d3b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits