jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394970 )
Change subject: Skip fewer tests in ViewEntityActionTest
......................................................................
Skip fewer tests in ViewEntityActionTest
Change-Id: I365440ba07e85f9e3b9f5c8309694a068601d3b1
---
M repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
b/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
index dff032d..d58d3d1 100644
--- a/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
+++ b/repo/tests/phpunit/includes/Actions/ViewEntityActionTest.php
@@ -102,6 +102,7 @@
$output = $this->executeViewAction( $page, $params );
$this->assertContains( 'diff-currentversion-title',
$output->getHTML(), 'is diff view' );
+ $this->markTestSkipped( 'Diff page is currently editable, needs
fixing: T181807' );
$this->assertNotEditable( $output );
}
@@ -191,7 +192,6 @@
}
private function assertNotEditable( OutputPage $output ) {
- $this->markTestSkipped( 'Diff page is currently editable, needs
fixing: T181807' );
$html = $output->getHTML();
$this->assertNotContains( 'wikibase-edittoolbar-container',
$html );
$this->assertNotContains( 'wikibase-toolbar-button-edit', $html
);
--
To view, visit https://gerrit.wikimedia.org/r/394970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I365440ba07e85f9e3b9f5c8309694a068601d3b1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
