Xqt has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395697 )
Change subject: [IMPR] use contextlib.closing for closing a file
......................................................................
[IMPR] use contextlib.closing for closing a file
Change-Id: Ic2c0b043d23065b95d34d9034eb27e3a3822f069
---
M scripts/data_ingestion.py
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/97/395697/1
diff --git a/scripts/data_ingestion.py b/scripts/data_ingestion.py
index a6628c1..8057a60 100755
--- a/scripts/data_ingestion.py
+++ b/scripts/data_ingestion.py
@@ -16,6 +16,7 @@
import base64
import codecs
+from contextlib import closing
import hashlib
import io
import os
@@ -291,7 +292,7 @@
pywikibot.error('%s could not be opened: %s' % (filename, e))
continue
- try:
+ with closing(f):
files = CSVReader(f, urlcolumn='url',
site=config_page.site,
dialect=configuration['csvDialect'],
@@ -303,8 +304,6 @@
site=None)
bot.run()
- finally:
- f.close()
if __name__ == "__main__":
--
To view, visit https://gerrit.wikimedia.org/r/395697
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2c0b043d23065b95d34d9034eb27e3a3822f069
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
