Dvogel hallowelt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395698 )

Change subject: Handle DISPLAYTITLE with "&"
......................................................................

Handle DISPLAYTITLE with "&"

Title got lost when using "&" because it was interpreted as html

Change-Id: Iab784f78fc51ba9b8d324ee2146715d43632933f
---
M UEModulePDF/includes/PDFPageProvider.class.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/98/395698/1

diff --git a/UEModulePDF/includes/PDFPageProvider.class.php 
b/UEModulePDF/includes/PDFPageProvider.class.php
index b18420a..9fd2ab5 100644
--- a/UEModulePDF/includes/PDFPageProvider.class.php
+++ b/UEModulePDF/includes/PDFPageProvider.class.php
@@ -68,7 +68,9 @@
 
                if( isset($aParams['display-title'] ) ) {
                        $oBookmarkNode->setAttribute( 'name', 
$aParams['display-title'] );
-                       $oFirstHeading->nodeValue = $aParams['display-title'];
+                       $oTitleText = 
$oFirstHeading->ownerDocument->createTextNode( $aParams['display-title'] );
++                      $oFirstHeading->nodeValue = '';
++                      $oFirstHeading->replaceChild( $oTitleText, 
$oFirstHeading->firstChild );
                        $aData['meta']['title']   = $aParams['display-title'];
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/395698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab784f78fc51ba9b8d324ee2146715d43632933f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Dvogel hallowelt <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to