[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use findItem(s)FromData instead getItem(s)FromData

[Prtksxna (Code Review)]

Prtksxna has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398224 )

Change subject: Use findItem(s)FromData instead getItem(s)FromData
......................................................................

Use findItem(s)FromData instead getItem(s)FromData

Depends-on: Ia2110f71d1642f61451cb8acc7e8a930d0feb31f
Bug: T76630
Change-Id: Iddd1d3f5abaa233adbf030114343a8ed248de28b
---
M modules/ui/mw.echo.ui.CrossWikiUnreadFilterWidget.js
M modules/ui/mw.echo.ui.NotificationsInboxWidget.js
M modules/ui/mw.echo.ui.PaginationWidget.js
M modules/ui/mw.echo.ui.SortedListWidget.js
4 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/24/398224/1

diff --git a/modules/ui/mw.echo.ui.CrossWikiUnreadFilterWidget.js 
b/modules/ui/mw.echo.ui.CrossWikiUnreadFilterWidget.js
index fe6d13f..5b5134c 100644
--- a/modules/ui/mw.echo.ui.CrossWikiUnreadFilterWidget.js
+++ b/modules/ui/mw.echo.ui.CrossWikiUnreadFilterWidget.js
@@ -159,10 +159,10 @@
                this.addItems( widgets );
 
                // Select the current source
-               selectedWidget = this.getItemFromData( selectedSource );
+               selectedWidget = this.findItemFromData( selectedSource );
                if ( selectedPage ) {
                        // Select a specific page
-                       item = selectedWidget.getItemFromData( selectedPage );
+                       item = selectedWidget.findItemFromData( selectedPage );
                } else {
                        // The wiki title is selected
                        item = selectedWidget.getTitleItem();
diff --git a/modules/ui/mw.echo.ui.NotificationsInboxWidget.js 
b/modules/ui/mw.echo.ui.NotificationsInboxWidget.js
index 6791ffe..e826361 100644
--- a/modules/ui/mw.echo.ui.NotificationsInboxWidget.js
+++ b/modules/ui/mw.echo.ui.NotificationsInboxWidget.js
@@ -168,7 +168,7 @@
         */
        
mw.echo.ui.NotificationsInboxWidget.prototype.updateReadStateSelectWidget = 
function () {
                this.readStateSelectWidget
-                       .getItemFromData( 
this.manager.getFiltersModel().getReadState() )
+                       .findItemFromData( 
this.manager.getFiltersModel().getReadState() )
                        .setSelected( true );
        };
 
diff --git a/modules/ui/mw.echo.ui.PaginationWidget.js 
b/modules/ui/mw.echo.ui.PaginationWidget.js
index 0a3208e..2a435dc 100644
--- a/modules/ui/mw.echo.ui.PaginationWidget.js
+++ b/modules/ui/mw.echo.ui.PaginationWidget.js
@@ -109,9 +109,9 @@
         * Update the state - disabled and visibility - of the sub widgets.
         */
        mw.echo.ui.PaginationWidget.prototype.updateWidgetState = function () {
-               this.dirSelectWidget.getItemFromData( 'prev' )
+               this.dirSelectWidget.findItemFromData( 'prev' )
                        .setDisabled( this.isDisabled() || 
!this.model.hasPrevPage() );
-               this.dirSelectWidget.getItemFromData( 'next' )
+               this.dirSelectWidget.findItemFromData( 'next' )
                        .setDisabled( this.isDisabled() || 
!this.model.hasNextPage() );
 
                this.startButton.toggle(
diff --git a/modules/ui/mw.echo.ui.SortedListWidget.js 
b/modules/ui/mw.echo.ui.SortedListWidget.js
index 591c0ad..1ae941e 100644
--- a/modules/ui/mw.echo.ui.SortedListWidget.js
+++ b/modules/ui/mw.echo.ui.SortedListWidget.js
@@ -136,7 +136,7 @@
         * @param {string} data Item data to search for
         * @return {OO.ui.Element|null} Item with equivalent data, `null` if 
none exists
         */
-       mw.echo.ui.SortedListWidget.prototype.getItemFromData = function ( data 
) {
+       mw.echo.ui.SortedListWidget.prototype.findItemFromData = function ( 
data ) {
                var i, len, item,
                        hash = OO.getHash( data );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/398224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddd1d3f5abaa233adbf030114343a8ed248de28b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits