星耀晨曦 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398225 )
Change subject: Compatible with php7.2, avoid passing null to count()
......................................................................
Compatible with php7.2, avoid passing null to count()
Bug: T182847
Change-Id: I0ab4555fc0669605528d5a14bbaa771cc88e0708
---
M BlueSkyTemplate.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/BlueSky
refs/changes/25/398225/1
diff --git a/BlueSkyTemplate.php b/BlueSkyTemplate.php
index 4bdd4bd..157bb16 100644
--- a/BlueSkyTemplate.php
+++ b/BlueSkyTemplate.php
@@ -32,7 +32,7 @@
$title = $skin->getTitle();
$request = $skin->getRequest();
$action = $request->getVal( 'action', 'view' );
- if ( count( $request->getVal( 'diff' ) ) > 0 ) {
+ if ( $request->getVal( 'diff' ) !== null && count(
$request->getVal( 'diff' ) ) > 0 ) {
$action = 'diff';
}
// We'll treat the mainpage like any other page if they're
doing something besides looking at it
--
To view, visit https://gerrit.wikimedia.org/r/398225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ab4555fc0669605528d5a14bbaa771cc88e0708
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/BlueSky
Gerrit-Branch: master
Gerrit-Owner: 星耀晨曦 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
