Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/401821 )

Change subject: Add debugging information to flakey test
......................................................................

Add debugging information to flakey test

Occasionally for unknown reasons this test fails to make an assertion.
Rather than doing that we'll make an assertion that always fails with the 
exception
that caused it. This should help us identify and fix the culprit.

Bug: T179959
Change-Id: I0c1d57dd0292bef605f05a22f984cd81b0131a96
---
M tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/21/401821/1

diff --git 
a/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js 
b/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
index 79511ca..21ec573 100644
--- a/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
+++ b/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
@@ -69,7 +69,9 @@
                return referencesGateway.getReference( '#cite_note-1', page 
).always( function () {
                        return referencesGateway.getReference( '#cite_note-2', 
page ).done( function ( ref ) {
                                assert.strictEqual( ref.text, 'real lazy 2' );
-                       } );
+                       } ).catch( function ( err ) {
+                               assert.ok( false, err );
+                       } )
                } );
        } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/401821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c1d57dd0292bef605f05a22f984cd81b0131a96
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to