jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/401821 )
Change subject: Add debugging information to flakey test
......................................................................
Add debugging information to flakey test
Occasionally for unknown reasons this test fails to make an assertion.
Rather than doing that we'll make an assertion that always fails with the
exception
that caused it. This should help us identify and fix the culprit.
Bug: T179959
Change-Id: I0c1d57dd0292bef605f05a22f984cd81b0131a96
---
M tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Pmiazga: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
b/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
index 79511ca..bf681a0 100644
--- a/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
+++ b/tests/qunit/mobile.references.gateway/test_ReferencesMobileViewGateway.js
@@ -69,6 +69,8 @@
return referencesGateway.getReference( '#cite_note-1', page
).always( function () {
return referencesGateway.getReference( '#cite_note-2',
page ).done( function ( ref ) {
assert.strictEqual( ref.text, 'real lazy 2' );
+ } ).catch( function ( err ) {
+ assert.ok( false, err );
} );
} );
} );
--
To view, visit https://gerrit.wikimedia.org/r/401821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c1d57dd0292bef605f05a22f984cd81b0131a96
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
