Subramanya Sastry has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403063 )
Change subject: Linter: Fix crasher in Cite - don't assume well-formedness
......................................................................
Linter: Fix crasher in Cite - don't assume well-formedness
Change-Id: Ie5da61934b91f115b0eea995e05de6c231d77bdb
---
M lib/ext/Cite/index.js
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/63/403063/1
diff --git a/lib/ext/Cite/index.js b/lib/ext/Cite/index.js
index d7f8f02..6e177d3 100644
--- a/lib/ext/Cite/index.js
+++ b/lib/ext/Cite/index.js
@@ -183,8 +183,11 @@
Ref.prototype.lintHandler = function(ref, env, tplInfo, domLinter) {
var linkBackId = ref.firstChild.getAttribute('href').replace(/[^#]*#/,
'');
- var refContent = ref.ownerDocument.getElementById(linkBackId).lastChild;
- domLinter(refContent, env, tplInfo.isTemplated ? tplInfo : null);
+ var refNode = ref.ownerDocument.getElementById(linkBackId)
+ if (refNode) {
+ // Ex: Buggy input wikitext without ref content
+ domLinter(refNode.lastChild, env, tplInfo.isTemplated ? tplInfo
: null);
+ }
return ref.nextNode;
};
--
To view, visit https://gerrit.wikimedia.org/r/403063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5da61934b91f115b0eea995e05de6c231d77bdb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
