jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403063 )
Change subject: Linter: Fix crasher in Cite - don't assume well-formedness
......................................................................
Linter: Fix crasher in Cite - don't assume well-formedness
Change-Id: Ie5da61934b91f115b0eea995e05de6c231d77bdb
---
M lib/ext/Cite/index.js
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Arlolra: Looks good to me, approved
diff --git a/lib/ext/Cite/index.js b/lib/ext/Cite/index.js
index d7f8f02..8f2f3d1 100644
--- a/lib/ext/Cite/index.js
+++ b/lib/ext/Cite/index.js
@@ -183,8 +183,11 @@
Ref.prototype.lintHandler = function(ref, env, tplInfo, domLinter) {
var linkBackId = ref.firstChild.getAttribute('href').replace(/[^#]*#/,
'');
- var refContent = ref.ownerDocument.getElementById(linkBackId).lastChild;
- domLinter(refContent, env, tplInfo.isTemplated ? tplInfo : null);
+ var refNode = ref.ownerDocument.getElementById(linkBackId);
+ if (refNode) {
+ // Ex: Buggy input wikitext without ref content
+ domLinter(refNode.lastChild, env, tplInfo.isTemplated ? tplInfo
: null);
+ }
return ref.nextNode;
};
--
To view, visit https://gerrit.wikimedia.org/r/403063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5da61934b91f115b0eea995e05de6c231d77bdb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: C. Scott Ananian <canan...@wikimedia.org>
Gerrit-Reviewer: Sbailey <sbai...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
