Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404045 )
Change subject: webperf: Re-use expected result by reference to simplify fixture
......................................................................
webperf: Re-use expected result by reference to simplify fixture
This makes it easier to review the fixture by knowing the addition
of isOversample=false produced the same output as without that key.
Change-Id: Ic7057f1818f3a25528b0cbd5da953c0e539b6cb4
---
M modules/webperf/files/navtiming_fixture.yaml
1 file changed, 2 insertions(+), 141 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/45/404045/1
diff --git a/modules/webperf/files/navtiming_fixture.yaml
b/modules/webperf/files/navtiming_fixture.yaml
index 867cc13..494a6eb 100644
--- a/modules/webperf/files/navtiming_fixture.yaml
+++ b/modules/webperf/files/navtiming_fixture.yaml
@@ -16,7 +16,7 @@
Uncached page view from desktop:
input: {"event": {"action": "history", "connectEnd": 6, "connectStart": 6,
"dnsLookup": 1, "domComplete": 1965, "domInteractive": 956, "fetchStart": 1,
"isAnon": false, "isHiDPI": false, "isHttp2": true, "loadEventEnd": 1968,
"loadEventStart": 1965, "mediaWikiLoadComplete": 1270, "mediaWikiVersion":
"1.30.0-wmf.19", "namespaceId": 1, "originCountry": "RS", "originRegion": "VO",
"pageId": 1, "requestStart": 6, "responseEnd": 415, "responseStart": 380,
"revId": 1, "unload": 4}, "recvFrom": "example", "revision": 1, "schema":
"NavigationTiming", "seqId": 1, "timestamp": 1, "userAgent": "{\"os_minor\":
null, \"is_bot\": false, \"os_major\": null, \"device_family\": \"Other\",
\"os_family\": \"Windows 8.1\", \"browser_minor\": \"0\", \"wmf_app_version\":
\"-\", \"browser_major\": \"55\", \"browser_family\": \"Firefox\",
\"is_mediawiki\": false}", "uuid": "example", "webHost": "example", "wiki":
"example"}
- expect:
+ expect: &expected_uncached_desktop
- frontend.navtiming.loadEventStart.desktop.authenticated:1965|ms
- frontend.navtiming.loadEventStart.desktop.overall:1965|ms
- frontend.navtiming.loadEventStart.overall:1965|ms
@@ -620,146 +620,7 @@
Uncached page view from desktop that includes isOversample=false:
input: {"event": {"action": "history", "connectEnd": 6, "connectStart": 6,
"dnsLookup": 1, "domComplete": 1965, "domInteractive": 956, "fetchStart": 1,
"isAnon": false, "isHiDPI": false, "isHttp2": true, "isOversample": false,
"loadEventEnd": 1968, "loadEventStart": 1965, "mediaWikiLoadComplete": 1270,
"mediaWikiVersion": "1.30.0-wmf.19", "namespaceId": 1, "originCountry": "RS",
"originRegion": "VO", "pageId": 1, "requestStart": 6, "responseEnd": 415,
"responseStart": 380, "revId": 1, "unload": 4}, "recvFrom": "example",
"revision": 1, "schema": "NavigationTiming", "seqId": 1, "timestamp": 1,
"userAgent": "{\"os_minor\": null, \"is_bot\": false, \"os_major\": null,
\"device_family\": \"Other\", \"os_family\": \"Windows 8.1\",
\"browser_minor\": \"0\", \"wmf_app_version\": \"-\", \"browser_major\":
\"55\", \"browser_family\": \"Firefox\", \"is_mediawiki\": false}", "uuid":
"example", "webHost": "example", "wiki": "example"}
- expect:
- - frontend.navtiming.loadEventStart.desktop.authenticated:1965|ms
- - frontend.navtiming.loadEventStart.desktop.overall:1965|ms
- - frontend.navtiming.loadEventStart.overall:1965|ms
- - frontend.navtiming.loadEventStart.by_browser.Firefox.55:1965|ms
- - frontend.navtiming.loadEventStart.by_browser.Firefox.all:1965|ms
- - frontend.navtiming.loadEventStart.by_continent.Europe:1965|ms
- - frontend.navtiming.dnsLookup.desktop.authenticated:1|ms
- - frontend.navtiming.dnsLookup.desktop.overall:1|ms
- - frontend.navtiming.dnsLookup.overall:1|ms
- - frontend.navtiming.dnsLookup.by_browser.Firefox.55:1|ms
- - frontend.navtiming.dnsLookup.by_browser.Firefox.all:1|ms
- - frontend.navtiming.dnsLookup.by_continent.Europe:1|ms
- - frontend.navtiming.mediaWikiLoadComplete.desktop.authenticated:1270|ms
- - frontend.navtiming.mediaWikiLoadComplete.desktop.overall:1270|ms
- - frontend.navtiming.mediaWikiLoadComplete.overall:1270|ms
- - frontend.navtiming.mediaWikiLoadComplete.by_browser.Firefox.55:1270|ms
- - frontend.navtiming.mediaWikiLoadComplete.by_browser.Firefox.all:1270|ms
- - frontend.navtiming.mediaWikiLoadComplete.by_continent.Europe:1270|ms
- - frontend.navtiming.loadEventEnd.desktop.authenticated:1968|ms
- - frontend.navtiming.loadEventEnd.desktop.overall:1968|ms
- - frontend.navtiming.loadEventEnd.overall:1968|ms
- - frontend.navtiming.loadEventEnd.by_browser.Firefox.55:1968|ms
- - frontend.navtiming.loadEventEnd.by_browser.Firefox.all:1968|ms
- - frontend.navtiming.loadEventEnd.by_continent.Europe:1968|ms
- - frontend.navtiming.waiting.desktop.authenticated:374|ms
- - frontend.navtiming.waiting.desktop.overall:374|ms
- - frontend.navtiming.waiting.overall:374|ms
- - frontend.navtiming.waiting.by_browser.Firefox.55:374|ms
- - frontend.navtiming.waiting.by_browser.Firefox.all:374|ms
- - frontend.navtiming.waiting.by_continent.Europe:374|ms
- - frontend.navtiming.connecting.by_continent.Europe:0|ms
- - frontend.navtiming.fetchStart.desktop.authenticated:1|ms
- - frontend.navtiming.fetchStart.desktop.overall:1|ms
- - frontend.navtiming.fetchStart.overall:1|ms
- - frontend.navtiming.fetchStart.by_browser.Firefox.55:1|ms
- - frontend.navtiming.fetchStart.by_browser.Firefox.all:1|ms
- - frontend.navtiming.fetchStart.by_continent.Europe:1|ms
- - frontend.navtiming.domComplete.desktop.authenticated:1965|ms
- - frontend.navtiming.domComplete.desktop.overall:1965|ms
- - frontend.navtiming.domComplete.overall:1965|ms
- - frontend.navtiming.domComplete.by_browser.Firefox.55:1965|ms
- - frontend.navtiming.domComplete.by_browser.Firefox.all:1965|ms
- - frontend.navtiming.domComplete.by_continent.Europe:1965|ms
- - frontend.navtiming.receiving.desktop.authenticated:35|ms
- - frontend.navtiming.receiving.desktop.overall:35|ms
- - frontend.navtiming.receiving.overall:35|ms
- - frontend.navtiming.receiving.by_browser.Firefox.55:35|ms
- - frontend.navtiming.receiving.by_browser.Firefox.all:35|ms
- - frontend.navtiming.receiving.by_continent.Europe:35|ms
- - frontend.navtiming.responseStart.desktop.authenticated:380|ms
- - frontend.navtiming.responseStart.desktop.overall:380|ms
- - frontend.navtiming.responseStart.overall:380|ms
- - frontend.navtiming.responseStart.by_browser.Firefox.55:380|ms
- - frontend.navtiming.responseStart.by_browser.Firefox.all:380|ms
- - frontend.navtiming.responseStart.by_continent.Europe:380|ms
- - frontend.navtiming.domInteractive.desktop.authenticated:956|ms
- - frontend.navtiming.domInteractive.desktop.overall:956|ms
- - frontend.navtiming.domInteractive.overall:956|ms
- - frontend.navtiming.domInteractive.by_browser.Firefox.55:956|ms
- - frontend.navtiming.domInteractive.by_browser.Firefox.all:956|ms
- - frontend.navtiming.domInteractive.by_continent.Europe:956|ms
- - frontend.navtiming2.onLoad.desktop.authenticated:3|ms
- - frontend.navtiming2.onLoad.desktop.overall:3|ms
- - frontend.navtiming2.onLoad.overall:3|ms
- - frontend.navtiming2.onLoad.by_browser.Firefox.55:3|ms
- - frontend.navtiming2.onLoad.by_browser.Firefox.all:3|ms
- - frontend.navtiming2.onLoad.by_continent.Europe:3|ms
- - frontend.navtiming2.dns.desktop.authenticated:1|ms
- - frontend.navtiming2.dns.desktop.overall:1|ms
- - frontend.navtiming2.dns.overall:1|ms
- - frontend.navtiming2.dns.by_browser.Firefox.55:1|ms
- - frontend.navtiming2.dns.by_browser.Firefox.all:1|ms
- - frontend.navtiming2.dns.by_continent.Europe:1|ms
- - frontend.navtiming2.unload.desktop.authenticated:4|ms
- - frontend.navtiming2.unload.desktop.overall:4|ms
- - frontend.navtiming2.unload.overall:4|ms
- - frontend.navtiming2.unload.by_browser.Firefox.55:4|ms
- - frontend.navtiming2.unload.by_browser.Firefox.all:4|ms
- - frontend.navtiming2.unload.by_continent.Europe:4|ms
- - frontend.navtiming2.processing.desktop.authenticated:1550|ms
- - frontend.navtiming2.processing.desktop.overall:1550|ms
- - frontend.navtiming2.processing.overall:1550|ms
- - frontend.navtiming2.processing.by_browser.Firefox.55:1550|ms
- - frontend.navtiming2.processing.by_browser.Firefox.all:1550|ms
- - frontend.navtiming2.processing.by_continent.Europe:1550|ms
- - frontend.navtiming2.request.desktop.authenticated:374|ms
- - frontend.navtiming2.request.desktop.overall:374|ms
- - frontend.navtiming2.request.overall:374|ms
- - frontend.navtiming2.request.by_browser.Firefox.55:374|ms
- - frontend.navtiming2.request.by_browser.Firefox.all:374|ms
- - frontend.navtiming2.request.by_continent.Europe:374|ms
- - frontend.navtiming2.tcp.desktop.authenticated:0|ms
- - frontend.navtiming2.tcp.desktop.overall:0|ms
- - frontend.navtiming2.tcp.overall:0|ms
- - frontend.navtiming2.tcp.by_browser.Firefox.55:0|ms
- - frontend.navtiming2.tcp.by_browser.Firefox.all:0|ms
- - frontend.navtiming2.tcp.by_continent.Europe:0|ms
- - frontend.navtiming2.loadEventEnd.desktop.authenticated:1967|ms
- - frontend.navtiming2.loadEventEnd.desktop.overall:1967|ms
- - frontend.navtiming2.loadEventEnd.overall:1967|ms
- - frontend.navtiming2.loadEventEnd.by_browser.Firefox.55:1967|ms
- - frontend.navtiming2.loadEventEnd.by_browser.Firefox.all:1967|ms
- - frontend.navtiming2.loadEventEnd.by_continent.Europe:1967|ms
- - frontend.navtiming2.loadEventStart.desktop.authenticated:1964|ms
- - frontend.navtiming2.loadEventStart.desktop.overall:1964|ms
- - frontend.navtiming2.loadEventStart.overall:1964|ms
- - frontend.navtiming2.loadEventStart.by_browser.Firefox.55:1964|ms
- - frontend.navtiming2.loadEventStart.by_browser.Firefox.all:1964|ms
- - frontend.navtiming2.loadEventStart.by_continent.Europe:1964|ms
- - frontend.navtiming2.response.desktop.authenticated:35|ms
- - frontend.navtiming2.response.desktop.overall:35|ms
- - frontend.navtiming2.response.overall:35|ms
- - frontend.navtiming2.response.by_browser.Firefox.55:35|ms
- - frontend.navtiming2.response.by_browser.Firefox.all:35|ms
- - frontend.navtiming2.response.by_continent.Europe:35|ms
- - frontend.navtiming2.domComplete.desktop.authenticated:1964|ms
- - frontend.navtiming2.domComplete.desktop.overall:1964|ms
- - frontend.navtiming2.domComplete.overall:1964|ms
- - frontend.navtiming2.domComplete.by_browser.Firefox.55:1964|ms
- - frontend.navtiming2.domComplete.by_browser.Firefox.all:1964|ms
- - frontend.navtiming2.domComplete.by_continent.Europe:1964|ms
- - frontend.navtiming2.responseStart.desktop.authenticated:379|ms
- - frontend.navtiming2.responseStart.desktop.overall:379|ms
- - frontend.navtiming2.responseStart.overall:379|ms
- - frontend.navtiming2.responseStart.by_browser.Firefox.55:379|ms
- - frontend.navtiming2.responseStart.by_browser.Firefox.all:379|ms
- - frontend.navtiming2.responseStart.by_continent.Europe:379|ms
- - frontend.navtiming2.domInteractive.desktop.authenticated:955|ms
- - frontend.navtiming2.domInteractive.desktop.overall:955|ms
- - frontend.navtiming2.domInteractive.overall:955|ms
- - frontend.navtiming2.domInteractive.by_browser.Firefox.55:955|ms
- - frontend.navtiming2.domInteractive.by_browser.Firefox.all:955|ms
- - frontend.navtiming2.domInteractive.by_continent.Europe:955|ms
- - frontend.navtiming2.mediaWikiLoad.desktop.authenticated:1270|ms
- - frontend.navtiming2.mediaWikiLoad.desktop.overall:1270|ms
- - frontend.navtiming2.mediaWikiLoad.overall:1270|ms
- - frontend.navtiming2.mediaWikiLoad.by_browser.Firefox.55:1270|ms
- - frontend.navtiming2.mediaWikiLoad.by_browser.Firefox.all:1270|ms
- - frontend.navtiming2.mediaWikiLoad.by_continent.Europe:1270|ms
+ expect: *expected_uncached_desktop
Uncached page view from desktop that includes isOversample=true:
input: {"event": {"action": "history", "connectEnd": 6, "connectStart": 6,
"dnsLookup": 1, "domComplete": 1965, "domInteractive": 956, "fetchStart": 1,
"isAnon": false, "isHiDPI": false, "isHttp2": true, "isOversample": true,
"loadEventEnd": 1968, "loadEventStart": 1965, "mediaWikiLoadComplete": 1270,
"mediaWikiVersion": "1.30.0-wmf.19", "namespaceId": 1, "originCountry": "RS",
"originRegion": "VO", "pageId": 1, "requestStart": 6, "responseEnd": 415,
"responseStart": 380, "revId": 1, "unload": 4}, "recvFrom": "example",
"revision": 1, "schema": "NavigationTiming", "seqId": 1, "timestamp": 1,
"userAgent": "{\"os_minor\": null, \"is_bot\": false, \"os_major\": null,
\"device_family\": \"Other\", \"os_family\": \"Windows 8.1\",
\"browser_minor\": \"0\", \"wmf_app_version\": \"-\", \"browser_major\":
\"55\", \"browser_family\": \"Firefox\", \"is_mediawiki\": false}", "uuid":
"example", "webHost": "example", "wiki": "example"}
--
To view, visit https://gerrit.wikimedia.org/r/404045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7057f1818f3a25528b0cbd5da953c0e539b6cb4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
