jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403985 )
Change subject: Fix alignment of Edit pencil when description editing is
disabled.
......................................................................
Fix alignment of Edit pencil when description editing is disabled.
When an article has no description, and description editing is disabled,
the edit pencil wasn't properly aligned.
Bug: T184825
Change-Id: I7a71ec7b77e189e9b47ae96d7952b0afff859dd1
---
M app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Cooltey: Looks good to me, approved
diff --git
a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
index 8072167..6e04581 100644
--- a/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/PageHeaderView.java
@@ -274,7 +274,7 @@
subtitleText.setText(subtitleSpanned());
subtitleText.setVisibility(VISIBLE);
} else {
- subtitleText.setVisibility(GONE);
+ subtitleText.setVisibility(INVISIBLE);
}
}
--
To view, visit https://gerrit.wikimedia.org/r/403985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a71ec7b77e189e9b47ae96d7952b0afff859dd1
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
