Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58432
Change subject: Making 'More...' link in archive more prominent per Vibha
......................................................................
Making 'More...' link in archive more prominent per Vibha
Change-Id: Ibbed21c5efd7ce1f6893c92a7f98ba60a63e98ab
---
M modules/special/ext.echo.special.css
M modules/special/ext.echo.special.js
M special/SpecialNotifications.php
3 files changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/32/58432/1
diff --git a/modules/special/ext.echo.special.css
b/modules/special/ext.echo.special.css
index 00f1969..630a460 100644
--- a/modules/special/ext.echo.special.css
+++ b/modules/special/ext.echo.special.css
@@ -11,7 +11,6 @@
text-align: center;
font-size: 13px;
max-width: 600px;
- margin-left: 45px;
}
#mw-echo-pref-link {
diff --git a/modules/special/ext.echo.special.js
b/modules/special/ext.echo.special.js
index 751791d..a659964 100644
--- a/modules/special/ext.echo.special.js
+++ b/modules/special/ext.echo.special.js
@@ -14,8 +14,13 @@
*/
'initialize': function() {
var _this = this;
- $( '#mw-echo-more' ).click(
- function( e ) {
+ // Convert more link into a button
+ $( '#mw-echo-more a' )
+ .button()
+ .width( '100%' )
+ .css( 'margin', '0.5em 0 0 0' )
+ .addClass( 'ui-button-blue' )
+ .click( function( e ) {
e.preventDefault();
if ( !_this.processing ) {
_this.processing = true;
diff --git a/special/SpecialNotifications.php b/special/SpecialNotifications.php
index 4702d7f..b6ca466 100644
--- a/special/SpecialNotifications.php
+++ b/special/SpecialNotifications.php
@@ -5,7 +5,7 @@
/**
* Number of notification records to display per page/load
*/
- private static $displayNum = 10;
+ private static $displayNum = 20;
public function __construct() {
parent::__construct( 'Notifications' );
@@ -86,7 +86,7 @@
// Build the more link
if ( $more ) {
// This is for no-javascript fallback
- $url = Html::element(
+ $moreLink = Html::element(
'a',
array(
'href' => SpecialPage::getTitleFor(
'Notifications' )->getLinkURL(
@@ -96,7 +96,7 @@
wfMessage( 'moredotdotdot' )->text()
);
- $html .= Html::rawElement( 'div', array( 'id' =>
'mw-echo-more' ), $url );
+ $html .= Html::rawElement( 'div', array( 'id' =>
'mw-echo-more' ), $moreLink );
}
$out->addHTML( $html );
--
To view, visit https://gerrit.wikimedia.org/r/58432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbed21c5efd7ce1f6893c92a7f98ba60a63e98ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
