jenkins-bot has submitted this change and it was merged.
Change subject: Making 'More...' link in archive more prominent per Vibha
......................................................................
Making 'More...' link in archive more prominent per Vibha
Change-Id: Ibbed21c5efd7ce1f6893c92a7f98ba60a63e98ab
---
M modules/special/ext.echo.special.css
M modules/special/ext.echo.special.js
M special/SpecialNotifications.php
3 files changed, 12 insertions(+), 9 deletions(-)
Approvals:
Bsitu: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/special/ext.echo.special.css
b/modules/special/ext.echo.special.css
index 00f1969..65b114c 100644
--- a/modules/special/ext.echo.special.css
+++ b/modules/special/ext.echo.special.css
@@ -8,10 +8,10 @@
/* Echo specific CSS */
#mw-echo-more {
+ display: block;
text-align: center;
font-size: 13px;
max-width: 600px;
- margin-left: 45px;
}
#mw-echo-pref-link {
diff --git a/modules/special/ext.echo.special.js
b/modules/special/ext.echo.special.js
index 751791d..00eb2ea 100644
--- a/modules/special/ext.echo.special.js
+++ b/modules/special/ext.echo.special.js
@@ -14,8 +14,13 @@
*/
'initialize': function() {
var _this = this;
- $( '#mw-echo-more' ).click(
- function( e ) {
+ // Convert more link into a button
+ $( '#mw-echo-more' )
+ .button()
+ // Override jQuery UI button margins
+ .css( 'margin', '0.5em 0 0 0' )
+ .addClass( 'ui-button-blue' )
+ .click( function( e ) {
e.preventDefault();
if ( !_this.processing ) {
_this.processing = true;
diff --git a/special/SpecialNotifications.php b/special/SpecialNotifications.php
index 4702d7f..0bcdf64 100644
--- a/special/SpecialNotifications.php
+++ b/special/SpecialNotifications.php
@@ -5,7 +5,7 @@
/**
* Number of notification records to display per page/load
*/
- private static $displayNum = 10;
+ private static $displayNum = 20;
public function __construct() {
parent::__construct( 'Notifications' );
@@ -85,18 +85,16 @@
// Build the more link
if ( $more ) {
- // This is for no-javascript fallback
- $url = Html::element(
+ $html .= Html::element(
'a',
array(
'href' => SpecialPage::getTitleFor(
'Notifications' )->getLinkURL(
array( 'paging'
=> intval( $nextTimestamp ) . '|' . intval( $nextOffset ) )
- )
+ ),
+ 'id' => 'mw-echo-more'
),
wfMessage( 'moredotdotdot' )->text()
);
-
- $html .= Html::rawElement( 'div', array( 'id' =>
'mw-echo-more' ), $url );
}
$out->addHTML( $html );
--
To view, visit https://gerrit.wikimedia.org/r/58432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbed21c5efd7ce1f6893c92a7f98ba60a63e98ab
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Lwelling <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
